Skip to content

HADOOP-17388. AbstractS3ATokenIdentifier to issue date in UTC#2477

Merged
steveloughran merged 1 commit intoapache:trunkfrom
HeartSaVioR:HADOOP-17388-trunk
Nov 20, 2020
Merged

HADOOP-17388. AbstractS3ATokenIdentifier to issue date in UTC#2477
steveloughran merged 1 commit intoapache:trunkfrom
HeartSaVioR:HADOOP-17388-trunk

Conversation

@HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Nov 20, 2020

In HADOOP-17379, I missed to set issue date as local timezone sensitive, whereas we actually set issue date in UTC.

hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

Lines 418 to 439 in 0705033

@Override
protected synchronized byte[] createPassword(TokenIdent identifier) {
int sequenceNum;
long now = Time.now();
sequenceNum = incrementDelegationTokenSeqNum();
identifier.setIssueDate(now);
identifier.setMaxDate(now + tokenMaxLifetime);
identifier.setMasterKeyId(currentKey.getKeyId());
identifier.setSequenceNumber(sequenceNum);
LOG.info("Creating password for identifier: " + formatTokenId(identifier)
+ ", currentKey: " + currentKey.getKeyId());
byte[] password = createPassword(identifier.getBytes(), currentKey.getKey());
DelegationTokenInformation tokenInfo = new DelegationTokenInformation(now
+ tokenRenewInterval, password, getTrackingIdIfEnabled(identifier));
try {
storeToken(identifier, tokenInfo);
} catch (IOException ioe) {
LOG.error("Could not store token " + formatTokenId(identifier) + "!!",
ioe);
}
return password;
}

This PR fixes the issue.

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Nov 20, 2020

cc. @steveloughran Appreciate your review. Thanks!

@hadoop-yetus

This comment has been minimized.

Sign in to view
@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Nov 20, 2020

Rationalization of no new test: tests were addressed in HADOOP-17379. Please let me know if we need to improve the test to strictly check for issue date that current time of UTC is returned.

asflicense looks to be false alarm, or real issue brought from other PR.

@steveloughran
Copy link
Contributor

steveloughran commented Nov 20, 2020

ASF license is an independent and I need to work out what's up there. We deleted those files earlier in the week, see

@steveloughran
Copy link
Contributor

steveloughran commented Nov 20, 2020

LGTM, +1

@steveloughran steveloughran merged commit f3c629c into apache:trunk Nov 20, 2020
asfgit pushed a commit that referenced this pull request Nov 20, 2020
@HeartSaVioR @steveloughran
HADOOP-17388. AbstractS3ATokenIdentifier to issue date in UTC. (#2477)
401cadb 
Followup to HADOOP-17379.

Contributed by Jungtaek Lim.

Change-Id: I7b2fce36028d297c1e095499691a08caba92d9fd
@steveloughran
Copy link
Contributor

steveloughran commented Nov 20, 2020

+1, merged to 3.3+

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Nov 21, 2020

Thanks for reviewing and merging!

jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@HeartSaVioR @steveloughran
CDPD-19493. HADOOP-17388. AbstractS3ATokenIdentifier to issue date in…
1f66810 
… UTC. (apache#2477)

Followup to HADOOP-17379.

Contributed by Jungtaek Lim.

Change-Id: I7b2fce36028d297c1e095499691a08caba92d9fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeartSaVioR @hadoop-yetus @steveloughran